-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posting to blue sky working #3004
base: main
Are you sure you want to change the base?
Conversation
@DonnieBLT sir , Please feel free to review and suggest any changes. |
For the failing test case ... |
@DonnieBLT sir , had one pending doubt here, regarding the regenertation of the lock file.
|
@DonnieBLT sir, is this good for merge? |
website/models.py
Outdated
post_data = f"{self.title}\n\n{self.description}" | ||
# If image exists, include it | ||
if self.image: | ||
print("image = " + self.image.path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the print statements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure on it.
@login_required | ||
@require_POST | ||
def like_activity(request, id): | ||
activity = get_object_or_404(Activity, id=id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have like and dislike on issues I wanted to check is there anyway that we could reuse the same models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The like and dislike functionality for issues differs significantly from the implementation for activities:
Issue likes and dislikes are linked directly to the user profile model (issue_upvoted, issue_downvoted).
However, we don’t want to store activity likes and dislikes in a similar manner, as it would be redundant.
Currently, an email is sent to the user every time their issue is liked. Sending another email when their issue is liked via the activity feed would be redundant.
That said, we can send an email notification if their content is featured on Blue Sky.
Conclusion:
While this can be implemented, it would require many if-else conditions, making the code more complex.
Fixes #2955
Solution Description:
Implementation details :
Bugs:
1.Currently for photos post its showing the alt text instead of the image in blue sky even though photo is going through the endpoint.
Requirements:
In enviroment variables make sure to add:
BLUESKY_USERNAME=example.bsky.social
BLUESKY_PASSWORD='example#123'
Here's a demo of the working:
Screen.Recording.2024-11-29.at.12.43.13.AM.mov